Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Info Not Displaying #366

Closed
gDollaZ opened this issue Feb 24, 2021 · 5 comments
Closed

Match Info Not Displaying #366

gDollaZ opened this issue Feb 24, 2021 · 5 comments

Comments

@gDollaZ
Copy link
Contributor

gDollaZ commented Feb 24, 2021

Example link leaves blank info section:
https://www.w3champions.com/match/6034205f7e9f54f8aae257b3

$ curl -X GET https://website-backend.w3champions.com/api/matches/6034205f7e9f54f8aae257b3

Seems to return the expected values....

Console error:

TypeError: e.scoresOfWinners[n] is undefined
po https://w3champions.wc3.tools/prod/site/js/app.c5030843.js:1
He https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
po https://w3champions.wc3.tools/prod/site/js/app.c5030843.js:1
_render https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
r https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
get https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
run https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
Zn https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
pe https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
ce https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
chunk-vendors.5b35b4a3.js:63:12041
ie https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
re https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
ee https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
_render https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
r https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
get https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
run https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
Zn https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
pe https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63
ce https://w3champions.wc3.tools/prod/site/js/chunk-vendors.5b35b4a3.js:63

@joleb
Copy link
Contributor

joleb commented Feb 25, 2021

should be related to #354

@Cepheid-UK
Copy link
Member

@joleb is this issue resolved going forward?

@joleb
Copy link
Contributor

joleb commented Jul 26, 2021

@Cepheid-UK should be resolved, i added fallback values in case the api returns undefined.

@Cepheid-UK
Copy link
Member

Cepheid-UK commented Jul 29, 2021

#354 is resolved but still some issues, @joleb offered this commit which fixed some issues but not others cb4783a.

We need to better determine the difference between a 0 and a null. I've not investigated whether this is a backend or a frontend issue, but knowing Javascript, I assume frontend? 😄

@Cepheid-UK
Copy link
Member

I recall this being fixed now @joleb? you can do the honours of closing this if so.

@joleb joleb closed this as completed Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants