-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve hashing speed #33
Comments
I've added a warning on the bytes method. We'll add benchmarks eventually and then compare with |
Aside from either using Blake2x directly or doing a ChaCha variant of STROBE. We could give Keccak STROBE a fast mode, likely along the lines of KangarooTwelve. See debris/tiny-keccak#41 |
I'm going to close this since the ship sailed and we're using merlin now. :) |
We almost always use merlin for hashing, but merlin is not optimized for large amounts of data, thus making
SigningTranscript::bytes
slow. We should look into blake2x and/or develop a chacha based strobe variant and/or encourage using theSigningTranscript::hash256
method instead. See paritytech/substrate#2415The text was updated successfully, but these errors were encountered: