Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating a rectangle transform it into a non-rectangle polygon #71

Open
nchevobbe opened this issue Jun 4, 2020 · 3 comments
Open

Rotating a rectangle transform it into a non-rectangle polygon #71

nchevobbe opened this issue Jun 4, 2020 · 3 comments

Comments

@nchevobbe
Copy link

Hello there, first of all, thanks for providing such a useful library :)

I think I'm seeing something odd with rotation.
Basically, when a transform is enabled on a rectangle, after rotating it, its diagonals don't have the same distance anymore (which is one of the rule that allow to check that a polygon is a rectangle).

I made a small test app so you can see by yourself: https://leaflet-path-transform.glitch.me/

let me know if you need more information.

@Groxot
Copy link

Groxot commented Jun 9, 2020

#39

@Groxot
Copy link

Groxot commented Jun 9, 2020

worked here.
https://github.com/kevinsamyn/Leaflet.Path.Transform/blob/master/dist/L.Path.Transform-src.js
But in this repo changed only dist file.

@nchevobbe
Copy link
Author

Hey @Groxot , thanks a lot!
I tried your version at https://leaflet-path-transform.glitch.me/
It looks a lot better, but the diagonals are still not equal when rotating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants