Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page disappears in Chrome v67 #45

Open
Katrienvh opened this issue Jun 20, 2018 · 7 comments
Open

Page disappears in Chrome v67 #45

Katrienvh opened this issue Jun 20, 2018 · 7 comments

Comments

@Katrienvh
Copy link

Some parts or sometimes the whole page disappears after rendering. We have this problem in the most of our projects, for example: https://www.avocom.be/. The whole page is white, but when you scroll, it appears again.

It is possible that you do will not see the issue the first time you visit the website. I suggest you to navigate to another page, move you pointer on the menu items and hover, refresh, repeat this until you see the problem. You should see the problem after a few times.

This issue is only visible in Chrome. We found out that it started from version 67.0.3396.87 (Official Build) (64-bit). I already did a bug report to Chrome. In the previous version of Chrome (66.0.3359.181 (Official Build) (64-bit)), the issue did not exist.

We found out that when we stop using Sweet scroll the issue is solved.

Wrong rendering
image

Correct rendering
image

Wrong rendering
image

Correct rendering
image
@Katrienvh
Copy link
Author

Katrienvh commented Jun 25, 2018 •
edited
Loading

I just removed sweet scroll from the example above (https://www.avocom.be/), so you can not see the issue anymore

@ramiejleh
Copy link

ramiejleh commented Jun 26, 2018 •
edited
Loading

I can also confirm that this issue is happening on chrome and after refreshing (Not on first load usually)
Hope it will get resolved soon.
Here is a page where the issue occurs: https://www.kilroy.dk/kontakt-os

@h6ah4i
Copy link

h6ah4i commented Jun 28, 2018 •
edited
Loading

@tsuyoshiwada I have also faced the same problem. Three weeks ago, I noticed it and just removed SweetScroll for workaround. The issue occurs when SweetScroll insert a temporary div element to body and immediately remove it to check whether the page can scroll or not.

@h6ah4i
Copy link

h6ah4i commented Jun 28, 2018

I have just created a patched version of SweetScroll. It uses different approach to find a scrollable element. It should work properly in most of cases, but might cause some incompatibility issues (*1).

You can try it, but AT YOUR OWN RISK 😜

https://github.com/h6ah4i/sweet-scroll/tree/feature/stop-using-temporary-div-to-detect-scrollable

package.json

{
  "dependencies": {
    "sweet-scroll": "h6ah4i/sweet-scroll#feature\/stop-using-temporary-div-to-detect-scrollable"
  }
}

*1: Current implementation assumes <body> element is always scrollable

@ramiejleh
Copy link

@h6ah4i Your solution almost works. But it breaks the plugin on safari/ios devices.

@h6ah4i
Copy link

h6ah4i commented Jul 18, 2018

@ramiejleh Thanks for the report. I'll take it a look 👀

@h6ah4i
Copy link

h6ah4i commented Oct 5, 2018

@ramiejleh Sorry for the very late reply. I have now fixed the compatibility issue with Safari/Edge browsers.

@h6ah4i h6ah4i mentioned this issue Oct 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@h6ah4i @Katrienvh @ramiejleh