Test Login page #87
Closed
Test Login page #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZrybeaWhitfield
requested changes
Feb 5, 2024
| const passwordInput = screen.getByPlaceholderText('Password') | ||
| const loginButton = screen.getByRole('button', { name: 'Login' }) | ||
|
|
||
| expect(usernameInput).toBeInTheDocument() |
There was a problem hiding this comment.
I am not sure about these assertions, its testing the rendering of the login form component which already has its own render tests. A better test could be rending the Login page with the image, LoginForm component mocked, and
then assert that all of those elements are present in the rendered Login page
There was a problem hiding this comment.
Also adding I think it should all be in 1 test. So a "good" Login page has to be rendered with all three- the Logo, , and and the para. This should be 1 test that asserts that all 3 are present.
MicahMartin
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.