Better error handling

[iperezx]

Can we get better error handling for this

waggle-bk-registration/ROOTFS/usr/bin/waggle-bk-registration.py

Line 124 in 856998a

logger.error(f"(get_certificates) error: {str(e)}")

I get this error:

2022-07-19 14:42:05,434  [registration-service:124] (ERROR): (get_certificates) error: Expecting value: line 1 column 1 (char 0)

[jswantek]

Do you have some suggestions? What would you like to see?

[iperezx]

I need to know on which part of the try section I am erroring out from:
https://github.com/waggle-sensor/waggle-bk-registration/blob/main/ROOTFS/usr/bin/waggle-bk-registration.py#L112-L121

Is it because I couldn't write_file for the public key, certificate, or private key? Or did I fail for request_node_info and why (for this case, I don't think I did, but let's just cover our bases).

[jswantek]

go ahead and suggest a PR

[seanshahkarami]

I think I noticed the same problem when testing my beekeeper PR.

I found that it was caused by me accidentally adding some extra log messages to BK's register.sh which broke that the registration service expects to get JSON. (see this note)

What you probably want to indicate is that it's malformed JSON (or use logger.exception to see the full traceback.)

[iperezx]

Thanks Sean. I have not modified anything that has not been tested on the dev docker-compose env. I think it might be the volume mounts.

I was working from latest, but I am going to fallback to v0.3.0 to isolate my issue.

You made this change: https://github.com/waggle-sensor/beekeeper/blob/main/bk-sshd/ROOTFS/opt/sage/beekeeper/register/register.sh#L41

How come you only check for certificate in the unit-test? https://github.com/waggle-sensor/beekeeper/blob/main/bk-api/test_bk_api.py#L47

You are doing a get next(https://github.com/waggle-sensor/beekeeper/blob/main/bk-api/test_bk_api.py#L49), but this is going to fail: https://github.com/waggle-sensor/waggle-bk-registration/blob/main/ROOTFS/usr/bin/waggle-bk-registration.py#L114-L120 when a new node registers with beekeeper.

[iperezx]

Or maybe its not since its over the ssh tunnel: https://github.com/waggle-sensor/waggle-bk-registration/blob/main/ROOTFS/usr/bin/waggle-bk-registration.py#L86

[seanshahkarami]

@iperezx Please let me know if this PR helps address some of this: waggle-sensor/beekeeper#27