Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eth-pm] display messages sent by the user on messsing box #187

Open
hackyguru opened this issue Jan 18, 2023 · 5 comments
Open

[eth-pm] display messages sent by the user on messsing box #187

hackyguru opened this issue Jan 18, 2023 · 5 comments
Assignees
@hackyguru
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hackyguru
Copy link
Collaborator

re : https://examples.waku.org/eth-pm/

in the above example, the messages sent by the user are not displayed in the messages box where as only the received messages are displayed - this makes the user feel like the messages are not getting sent.

img

expecting to fix this before ethdenver
@hackyguru hackyguru added the bug Something isn't working label Jan 18, 2023
@fryorcraken fryorcraken added this to Waku Jan 18, 2023
@danisharora099
Copy link
Contributor

Agreed - that sounds like a nice improvement!
Happy to take this up next week, or let me know if you prefer to work on this as it might help with some hands-on @hackyguru

@fryorcraken fryorcraken added enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working labels Jan 23, 2023
@danisharora099
Copy link
Contributor

@hackyguru following up on the above - will you be able to address this?

@hackyguru
Copy link
Collaborator Author

thanks for the headsup @danisharora099 , I'm hoping to complete this by this weekend.. Also making some minor additions that can help users understand what channels and broadcasting are.. I'll assign you to review the PR once it's done :)

@fryorcraken fryorcraken moved this to Triage in Waku Feb 22, 2023
@fryorcraken fryorcraken moved this from Triage to In Progress in Waku Feb 22, 2023
@danisharora099 danisharora099 removed their assignment Mar 14, 2023
@fryorcraken
Copy link
Collaborator

@hackyguru What is the status for this?

@danisharora099 danisharora099 moved this from In Progress to To Do in Waku Apr 13, 2023
@fryorcraken fryorcraken changed the title display messages sent by the user on messsing box [eth-pm] display messages sent by the user on messsing box Apr 21, 2023
@danisharora099
Copy link
Contributor

@hackyguru following up on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hackyguru hackyguru

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Waku
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danisharora099 @hackyguru @fryorcraken