Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better create protocol options #2073

Open
weboko opened this issue Jul 17, 2024 · 2 comments
Open

feat: better create protocol options #2073

weboko opened this issue Jul 17, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@weboko
Copy link
Collaborator

weboko commented Jul 17, 2024

This is a feature request

Problem

Currently options for creating a node are convoluted and spread in the code base.
It get harder to handle and requires some TS hacks to prevent from compilation.

Proposed Solutions

For starters we should split building of options and creation of libp2p which is main consumer of options.

const createOptions = buildCreateOptions(options);
const libp2p = await createLibp2pNode(createOptions);
const wakuNodeOptions = buildWakuNodeOptions(createOptions);

Second step is to consolidate leftover option updates specific for WakuNode:

const pingKeepAlive =

Notes

Draft PR: #2072

@weboko weboko added the enhancement New feature or request label Jul 17, 2024
@fryorcraken fryorcraken added this to Waku Jul 17, 2024
@weboko weboko moved this to Triage in Waku Jul 17, 2024
@weboko weboko moved this from Triage to To Do in Waku Jul 18, 2024
@danisharora099
Copy link
Collaborator

related to #2048

@weboko
Copy link
Collaborator Author

weboko commented Jul 19, 2024

another concern to be addressed - #2056 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

2 participants