Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: inconsistent protocol peer management #2147

Open
danisharora099 opened this issue Sep 30, 2024 · 0 comments · May be fixed by #2137
Open

bug: inconsistent protocol peer management #2147

danisharora099 opened this issue Sep 30, 2024 · 0 comments · May be fixed by #2137

Comments

@danisharora099
Copy link
Collaborator

This is a bug report

Problem

The current implementation showcased a lot of inconsistencies around peer management for protocols.
Multiple weird behaviour were observed:

  • protocol not able to find new peers from available pool, while it truly existed
  • peer renewal for a protocol was unsuccessful about the Peer Manager count didn't reflect that
  • protocol sometimes showed a count of available peers much greater than the total actually connected peers

Proposed Solutions

Implement thread-safe management using mutex locks

@danisharora099 danisharora099 linked a pull request Sep 30, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

Successfully merging a pull request may close this issue.

1 participant