Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make waitForRemotePeer part of the waku interface #1761

Closed
danisharora099 opened this issue Dec 18, 2023 · 2 comments · Fixed by #2155
Closed

chore: make waitForRemotePeer part of the waku interface #1761

danisharora099 opened this issue Dec 18, 2023 · 2 comments · Fixed by #2155
Assignees
@weboko
Labels
enhancement New feature or request

Comments

@danisharora099
Copy link
Collaborator

This is a change request

Problem

The current waitForRemotePeer utility takes in waku as the first argument. This function needs to be imported separately and then the node is passed to this function.

Proposed Solutions

It is much easier to just make waitForRemotePeer part of the waku class, and directly callable like node.waitForRemotePeer() thus also reducing one argument passed to the function.
@fryorcraken fryorcraken added this to Waku Dec 18, 2023
@chair28980
Copy link
Contributor

Note from js-waku pm 2023-12-20:

Might be a good idea to use this function within the node.start function.

@chair28980 chair28980 moved this to To Do in Waku Dec 20, 2023
@chair28980 chair28980 added the enhancement New feature or request label Dec 20, 2023
@weboko weboko mentioned this issue Oct 2, 2024
Merged
@github-project-automation github-project-automation bot moved this from To Do to Done in Waku Oct 4, 2024
@weboko weboko reopened this Oct 4, 2024
@weboko
Copy link
Collaborator

weboko commented Oct 4, 2024

Leftover to add .connect() operation to Waku node

@weboko weboko self-assigned this Oct 4, 2024
@weboko weboko moved this from Done to In Progress in Waku Oct 4, 2024
@weboko weboko mentioned this issue Oct 4, 2024
Merged
@weboko weboko closed this as completed Oct 10, 2024
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Oct 10, 2024
@weboko weboko mentioned this issue Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weboko weboko

Labels
enhancement New feature or request
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(lightPush): improve peer usage and improve readability waku-org/js-waku
3 participants
@chair28980 @danisharora099 @weboko