Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use submodule nph in CI to check lint #3027

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

fryorcraken
Copy link
Collaborator

Same as #2988 but uses nph v0.6.0

Copy link

github-actions bot commented Sep 10, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3027

Built from 0bd4d39

Copy link

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

@fryorcraken
Copy link
Collaborator Author

If approved, I can merge this one and close #2988

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks so much for it! 💯

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fryorcraken fryorcraken merged commit ce9a8c4 into master Sep 11, 2024
9 of 11 checks passed
@fryorcraken fryorcraken deleted the nph-0.6.0-lint-ci branch September 11, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants