Enhance light push protocol

[fryorcraken]

Summary

The Light Push protocol as currently defined is very bare.
After usage and implementations, the need of some features was raised:

• Returning errors a la filter with error code and description to clarify reason of failure:
• service node does not have enough relay peer in this mesh for this pubsub topic
• service node not subscrived to this pub sub topic
• message pushed is invalid/malformed
• timestamp out of range
• (future) RLN proof is invalid (or could be same as above)
• (future) this content topic is not served
• Returning information in case of success such as:
  • number of peers to whom the message was forwarded.

Considering the scope of change, backward compatibility should be possible and preferred

Acceptance Criteria

• Update RFC
• Implement changes

Tasks

• Define lightpush protocol response new structure and possible error codes in the RFC
  • feat: lightpush new protobuf proposal specs#20
• Redefine Lightpush response RPC and handle edge cases over relay.
  • feat: Enhance lightpush protocol error handling nwaku#2722
  • Update REST-API lightpush interface
• Update js-waku interface according to Lightpush protocol change
  • Adapt integration test cases to the protocol change.
• Update REST-API specification

[chaitanyaprem]

Adding the additional error case which was identified during waku-org/nwaku#2601 is

• In case messageSize crosses the configured network max-msg-size set for relay, respond with allowed messageSize

[fryorcraken]

What is the Status on that? is it done part of Req-Res DoS Protection? @Ivansete-status

[Ivansete-status]

What is the Status on that? is it done part of Req-Res DoS Protection? @Ivansete-status

Morning @fryorcraken! Thanks for the heads-up!
I think we have something done but I'm not sure about the actual implementation

@NagyZoltanPeter - Kindly share some insight about the implementation we did, if any. On the other hand, we need to create/link nwaku issues as a tasks of this [Epic] Enhance light push protocol, similarly as we are doing in the following epics:

• [Epic: nwaku] nwaku bindings #141
• [Epic: nwaku] PostgreSQL Maintenance nwaku#3072

Summarizing, if we haven't had the chance to look at it yet we need to create the necessary nwaku tasks, and link them to this epic, so that we can prioritize them from the nwaku PM sessions :)

Cheers

[NagyZoltanPeter]

What is the Status on that? is it done part of Req-Res DoS Protection? @Ivansete-status

Morning @fryorcraken! Thanks for the heads-up! I think we have something done but I'm not sure about the actual implementation

@NagyZoltanPeter - Kindly share some insight about the implementation we did, if any. On the other hand, we need to create/link nwaku issues as a tasks of this [Epic] Enhance light push protocol, similarly as we are doing in the following epics:

• [Epic: nwaku] nwaku bindings #141
• [Epic: nwaku] PostgreSQL Maintenance #147

Summarizing, if we haven't had the chance to look at it yet we need to create the necessary nwaku tasks, and link them to this epic, so that we can prioritize them from the nwaku PM sessions :)

Cheers

@fryorcraken, @Ivansete-status: Honestly I don't remembe why this one is in-progress as we have not implemented these enhancement on error codes for lightpush (currently we are returning a text description of the error or "Ok").
Also to be enhanced the relay's publish does not really propagate errors, only the peers count that succeeded to relay to.
In the last release @shash256 implemented message size validation.
If that ok I will create the issues on nwaku repo and link them here.

Also these are not in scope for DOS protection.

[fryorcraken]

This is part of #186 cc @chair28980