Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnvGWAS migration #27

Open
lgeistlinger opened this issue Apr 29, 2021 · 6 comments
Open

cnvGWAS migration #27

lgeistlinger opened this issue Apr 29, 2021 · 6 comments
Assignees

Comments

@lgeistlinger
Copy link
Collaborator

Hi @viniciushdasilva - I think it will be good to have a timeline for the migration. Will you be able to move things over until May 18th? That's the deadline for changes included in the upcoming Bioc3.13 release https://bioconductor.org/developers/release-schedule/? After that it will be another 6 months for the package being in the current state, so I think we should make an effort to meet the deadline.

@viniciushdasilva
Copy link
Collaborator

Agreed. I will merge a new cnvGWAS version until May 16th. Thus, we have time for some cosmetic improvements.

@viniciushdasilva
Copy link
Collaborator

Hi @lgeistlinger. I just updated a newer package version that performs linear regression without PLINK. Linear mixed models as present in dev branch will require further discussion as it depends on lme4qtl, which is not on CRAN.

@lgeistlinger
Copy link
Collaborator Author

Cool - thanks, Vinicius! I just pushed your changes on to Bioconductor.

Linear mixed models as present in dev branch will require further discussion as it depends on lme4qtl, which is not on CRAN.

I think here your options reduce to (i) convince the lme4qtl authors to submit to CRAN (which I remember they were not reponsive to), or (ii) copy the corresponding part that you need from lme4qtl into CNVRanger.

@viniciushdasilva
Copy link
Collaborator

We could try to convince the authors again. But they refused last time we did.

@lgeistlinger
Copy link
Collaborator Author

How much copying of code would it involve do you think? I think they are pretty set on not submitting to CRAN / Bioc.

@viniciushdasilva
Copy link
Collaborator

viniciushdasilva commented May 4, 2021

dev branch needs core functions from lme4qtl. We could try to invite lme4qtl authors to the next CNVRanger version and ask if we can copy the necessary code from lme4qtl into our package, at least until they manage to upload their package to a proper repository. Nevertheless, we could cite their publication in the cnvGWAS function help page and in our vignette explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants