Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing process ids otherwise inaccessible when filtering with org #109

Open
pranavparikh opened this issue Sep 1, 2020 · 5 comments
Open
Labels
question Further information is requested

Comments

@pranavparikh
Copy link
Contributor

When logged in with a non admin account , /api/v2/process?initiator=myusername&limit=50 doesn’t return the process id from the org where the user doesn't have access to. But we do see such process ids with this call /api/v2/process?orgName=notmyorgname&&initiator=nonadminuser&projectName=notmyproject&limit=50 . If the user doesn’t have access to the org and the project, should it still show the processes if filtered by the org and project name?

@pranavparikh pranavparikh added the question Further information is requested label Sep 1, 2020
@ibodrov
Copy link
Collaborator

ibodrov commented Sep 1, 2020

It should behave like the v1 version and judging by the code it already does the filtering based on the current user's orgs and projects, e.g. https://github.com/walmartlabs/concord/blob/master/server/impl/src/main/java/com/walmartlabs/concord/server/process/ProcessResourceV2.java#L252

Can you make a test to illustrate the issue?

@ibodrov
Copy link
Collaborator

ibodrov commented Nov 6, 2020

Hey @pranavparikh! Any updates? Should we keep the issue open?

@pranavparikh
Copy link
Contributor Author

@ibodrov ,
Let me try making a test

@ibodrov
Copy link
Collaborator

ibodrov commented Feb 26, 2021

@pranavparikh any progress or should we close this?

@pranavparikh
Copy link
Contributor Author

@ibodrov ,
Can you check out this test ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Development

No branches or pull requests

2 participants