-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Team BYOB On-Prem stopped to work (SUPPORTED_FILE_STORES) #272
Comments
From Flamarion Jorge Here is the repro I tested 3 different kinds of Object Storage (Ceph (RadosGW), Minio, and now AWS S3) the TEAM BYOB using the SUPPORTED_FILE_STORES and it doesn’t work consistently. Here is the test using AWS S3 (you can replicate to any other S3)
There was no content in the bucket, then I upload a random file and listed it again
This means the Access and Secret are valid (you can use it to test).
Theoretically, I can create a Team and assign the bucket flamarion-team-byob-test but it doesn’t happen. There’s a video and this is the log.
To ensure the test is not biased or tied to a strange S3 API, I used the AWS S3, in Sandbox account, Region eu-central-1 while the main bucket of my installation is my local Storage Ceph RadosGW
Please, let me know if there’s any other test I can do. have Minio too, if necessary I can do the tests using Minio (the same that worked in the past and that I reported here. https://weightsandbiases.slack.com/archives/C0123GDE0NM/p1705056205042069?thread_ts=1704995296.871159&cid=C0123GDE0NM |
@flamarion @levinandrew - Is this a current issue? Sorry I hadn't heard of this until now. Should not be in the consultant queue anyways. |
@flamarion @al I was incorrect in that scenario 2 worked without a code change. I could not connect from
local server instance
->minio bucket on my localhost
without making any code changes. I again had a false positive where the UI said the connection worked, and at the end of the day Thursday I forgot to check that backend actually was able to connect.I still do not know if the code is in a working state, and if it is, for what scenarios it works. I am going to note my observations here below, but keep in mind that they could be due to issues with my local setup.
I spin up the
local server instance
in a docker container, and theminio bucket on my localhost
in another docker container. Therefore, I still needed to use ngrok to get them to connect together. (I didn't yet have a chance to test spinning up the minio BYOB bucket in the same docker container.) So, for scenario 2 I needed to make these same code change that remove the AWS GetBucketRegion sdk call in order for the local gorilla app can connect to the bucket and upload objects to it. And the app can connect, and create a team.However, the SDK fails to upload. For example,
and then the logs show
The text was updated successfully, but these errors were encountered: