From 3e8aa1e0ce368a46cc97e12e445efc5314dc281f Mon Sep 17 00:00:00 2001
From: Tim Sweeney <tim@wandb.com>
Date: Wed, 6 Nov 2024 21:28:30 -0800
Subject: [PATCH] lint fix

---
 weave/trace_server/actions_worker/actions/llm_judge.py | 10 +++++-----
 weave/trace_server/actions_worker/dispatcher.py        |  6 +++---
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/weave/trace_server/actions_worker/actions/llm_judge.py b/weave/trace_server/actions_worker/actions/llm_judge.py
index f22cd1a17315..5ba23d5bdc4f 100644
--- a/weave/trace_server/actions_worker/actions/llm_judge.py
+++ b/weave/trace_server/actions_worker/actions/llm_judge.py
@@ -44,14 +44,14 @@ def do_llm_judge_action(
     completion = trace_server.completions_create(
         CompletionsCreateReq(
             project_id=project_id,
-            inputs=dict(
-                model=model,
-                messages=[
+            inputs={
+                "model": model,
+                "messages": [
                     {"role": "system", "content": system_prompt},
                     {"role": "user", "content": json.dumps(args)},
                 ],
-                response_format=response_format,
-            ),
+                "response_format": response_format,
+            },
             track_llm_call=False,
         )
     )
diff --git a/weave/trace_server/actions_worker/dispatcher.py b/weave/trace_server/actions_worker/dispatcher.py
index 74828356ada6..9111e8d5026d 100644
--- a/weave/trace_server/actions_worker/dispatcher.py
+++ b/weave/trace_server/actions_worker/dispatcher.py
@@ -60,11 +60,11 @@ def execute_batch(
     # 1. Lookup the action definition
     parsed_ref = parse_internal_uri(batch_req.action_ref)
     if parsed_ref.project_id != project_id:
-        raise ValueError(
+        raise TypeError(
             f"Action ref {batch_req.action_ref} does not match project_id {project_id}"
         )
     if not isinstance(parsed_ref, InternalObjectRef):
-        raise ValueError(f"Action ref {batch_req.action_ref} is not an object ref")
+        raise TypeError(f"Action ref {batch_req.action_ref} is not an object ref")
 
     action_def_read = trace_server.obj_read(
         ObjReadReq(
@@ -124,7 +124,7 @@ def publish_results_as_feedback(
     weave_ref = InternalCallRef(project_id, call_id).uri()
     parsed_action_ref = parse_internal_uri(action_ref)
     if not isinstance(parsed_action_ref, (InternalObjectRef, InternalOpRef)):
-        raise ValueError(f"Invalid action ref: {action_ref}")
+        raise TypeError(f"Invalid action ref: {action_ref}")
     action_name = parsed_action_ref.name
     return trace_server.feedback_create(
         FeedbackCreateReq(