fix(weave): Unbreak editing and deleting choices #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=c03ea9bd0b212286b24be4f6f9133afb5ff2d61c |
jwlee64
commented
Dec 18, 2024
| setPlaygroundStateFromTraceCall, | ||
| callWithCosts.result, | ||
| ]); | ||
| // Only set the call the first time the page loads, and we get the call |
There was a problem hiding this comment.
this was rerunnning every render because of callwithCosts.result
There was a problem hiding this comment.
hmmm, but isn't callwithCosts.result expensive? shouldn't that not be changing?
jwlee64
changed the title
shawnlewis
approved these changes
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
on any state change we would reload the intial trace
deleting choices was broken
if you deleted all the choices it would break as well
Testing
How was this PR tested?