Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wandb.init latency problems #3441

Open
jdai1 opened this issue Jan 19, 2025 · 2 comments
Open

Wandb.init latency problems #3441

jdai1 opened this issue Jan 19, 2025 · 2 comments

Comments

@jdai1
Copy link

jdai1 commented Jan 19, 2025

Hello,

I've been trying Weave out, and I think it's good so far. However, I have a problem with the startup times of wandb.init. It's adding about 3-4 seconds of latency which is a big problem for deploying the tracing in production. I've narrowed down the problem (I believe) to the autopatching of many different types of LLMs. I'm wondering if there could be an option added such that autopatching is turned off, or the user can specify which autopatchings are desired, such that ones that are not needed do not pile onto the latency.

Any other ideas to improve latency would also be welcome.

Thanks!
Julian

@jamie-rasmussen
Copy link
Collaborator

In the PR above I've created a small benchmarking script for weave.init, and added an option to disable the autopatching. I'll follow up with our team about whether this is an approach we want to ship. In the small amount of testing I did on my machine, disabling autopatch brings the init time from roughly 1.5 seconds down to 0.5 seconds. (Since these numbers are different than the 3-4s you experienced it could be helpful if you were willing to run that script on your own machine.)

I timed a few other things that happen in weave.init, e.g. our version check takes about 0.1s. Besides the autopatching I didn't see any immediately obvious quick performance wins.

@jdai1
Copy link
Author

jdai1 commented Jan 20, 2025

Thank you so much for the quick turn around! I think the feature is useful and would be good for users to ship. Quick question: in your PR, you mentioned there already is a way to disable single integrations. Could you point me to something or provide a snippet that shows how that can be done please? Couldn't find anything in the documentation so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants