diff --git a/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/DataTableView.tsx b/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/DataTableView.tsx index 9a954858926c..b54c35104dc3 100644 --- a/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/DataTableView.tsx +++ b/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/DataTableView.tsx @@ -392,7 +392,7 @@ export const DataTableView: FC<{ const displayRows = 10; const hideFooter = USE_TABLE_FOR_ARRAYS && gridRows.length <= displayRows; const headerHeight = 40; - const footerHeight = 52; + const footerHeight = 40; const rowHeight = 36; const contentHeight = rowHeight * Math.min(displayRows, gridRows.length); const loadingHeight = 100; diff --git a/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTable.tsx b/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTable.tsx index 3632664aaf09..afa22fa5b395 100644 --- a/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTable.tsx +++ b/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTable.tsx @@ -965,6 +965,7 @@ export const CallsTable: FC<{ // This moves the pagination controls to the left '& .MuiDataGrid-footerContainer': { justifyContent: 'flex-start', + minHeight: 40, }, '& .MuiDataGrid-main:focus-visible': { outline: 'none', @@ -1022,7 +1023,9 @@ export const CallsTable: FC<{ ); }, columnMenu: CallsCustomColumnMenu, - pagination: PaginationButtons, + pagination: props => ( + + ), columnMenuSortDescendingIcon: IconSortDescending, columnMenuSortAscendingIcon: IconSortAscending, columnMenuHideIcon: IconNotVisible, diff --git a/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTableButtons.tsx b/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTableButtons.tsx index 1892c085396a..b2b36a4b20ec 100644 --- a/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTableButtons.tsx +++ b/weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallsPage/CallsTableButtons.tsx @@ -9,9 +9,10 @@ import { useGridApiContext, useGridSelector, } from '@mui/x-data-grid-pro'; -import {MOON_500} from '@wandb/weave/common/css/color.styles'; +import {MOON_400, MOON_500} from '@wandb/weave/common/css/color.styles'; import {useOrgName} from '@wandb/weave/common/hooks/useOrganization'; import {useViewerUserInfo2} from '@wandb/weave/common/hooks/useViewerUserInfo'; +import {isMac} from '@wandb/weave/common/util/browser'; import {Radio, Switch} from '@wandb/weave/components'; import {Button} from '@wandb/weave/components/Button'; import {CodeEditor} from '@wandb/weave/components/CodeEditor'; @@ -26,6 +27,7 @@ import classNames from 'classnames'; import React, {Dispatch, FC, SetStateAction, useRef, useState} from 'react'; import * as userEvents from '../../../../../../integrations/analytics/userEvents'; +import {usePeekLocation} from '../../context'; import {useWFHooks} from '../wfReactInterface/context'; import {Query} from '../wfReactInterface/traceServerClientInterface/query'; import { @@ -646,12 +648,91 @@ curl '${baseUrl}/calls/stream_query' \\ return baseCurl; } -export const PaginationButtons = () => { +const CellFilterCallout: FC = () => ( + + + {isMac ? 'Option' : 'Alt'} + + + + + Click + + on a cell to filter by the value + +); + +const PaginationControls: FC<{ + page: number; + pageCount: number; + start: number; + end: number; + rowCount: number; + onPrevPage: () => void; + onNextPage: () => void; +}> = ({page, pageCount, start, end, rowCount, onPrevPage, onNextPage}) => ( + +