Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply comments lost when submitting with regular comments #204

Open
mplanchard opened this issue Mar 22, 2022 · 0 comments
Open

Reply comments lost when submitting with regular comments #204

mplanchard opened this issue Mar 22, 2022 · 0 comments

Comments

@mplanchard
Copy link

Describe the bug
When submitting a review (on GitHub) with both regular comments and reply comments, an error is thrown and the reply comments are lost (they do not show up on GitHub, and they disappear from the code-review interface).

The error is:

error in process filter: code-review-github-errback: Wrong type argument: characterp, (resource . "PullRequestReviewComment")
error in process filter: Wrong type argument: characterp, (resource . "PullRequestReviewComment")

To Reproduce

  1. Start a code review on which there are already some comments
  2. Add some comments with code-review-comment-add-or-edit
  3. Add some reply comments by calling code-review-comment-add-or-edit on existing comments
  4. Submit feedback (e.g. approve, request changes, comment)

Expected behavior
Ideally both reply comments and regular comments should be submitted. If only regular comments are submitted, though, the reply comments should at least be kept to avoid losing work so that they can then be submitted individually with code-review-submit-only-replies

Screenshots
N/A

Desktop (please complete the following information):

  • OS: NixOS 21.11
  • Emacs: 29.0.50 ca3858563c7ba8ee3caa82fbd2b7c386ea60c0d3
  • Doom core: v3.0.0-alpha
  • Doom modules: v21.12.0-alpha
  • code-review: ccc3795

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant