Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPy support #177

Open
m-rossi opened this issue Aug 28, 2022 · 2 comments
Open

PyPy support #177

m-rossi opened this issue Aug 28, 2022 · 2 comments

Comments

@m-rossi
Copy link
Contributor

m-rossi commented Aug 28, 2022

conda-forge recently started a migration for PyPy 3.8 and PyPy 3.9: conda-forge/dtaidistance-feedstock#11

The builds seems fine, however the import tests fail

import: 'dtaidistance'
Traceback (most recent call last):
  File "D:\bld\dtaidistance_1661547543219\test_tmp\run_test.py", line 2, in <module>
    import dtaidistance
  File "D:\bld\dtaidistance_1661547543219\_test_env\lib\site-packages\dtaidistance\__init__.py", line 19, in <module>
    from . import dtw
  File "D:\bld\dtaidistance_1661547543219\_test_env\lib\site-packages\dtaidistance\dtw.py", line 18, in <module>
    from . import util
  File "D:\bld\dtaidistance_1661547543219\_test_env\lib\site-packages\dtaidistance\util.py", line 31, in <module>
    from . import dtw_cc
  File "dtaidistance\dtw_cc.pyx", line 1, in init dtaidistance.dtw_cc
    """
ValueError: array.array size changed, may indicate binary incompatibility. Expected 72 from C header, got 24 from PyObject

Have you tried supporting PyPy for dtaidistance?

@wannesm
Copy link
Owner

wannesm commented Aug 29, 2022

Thanks for testing. I haven't tried before to support PyPy and can recreate the error. But what I get from the Cython issues is that array.array is not supported for PyPy: cython/cython#1818 . It would thus require refactoring the Cython code to get it to work in PyPy (unless I'm overlooking something).

@m-rossi
Copy link
Contributor Author

m-rossi commented Aug 29, 2022

Ok, i will put the PR in "Draft mode" then (Migrators and Migrations) to show it is currently not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants