Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alchemy/zippy, Member::getLatsModifiedDate() return DateTime, not string #43

Open
rotdrop opened this issue May 28, 2024 · 0 comments
Open

Comments

@rotdrop
Copy link
Contributor

rotdrop commented May 28, 2024

Hi there,

I think I stumbled over a bug here:

$member = $this->getMember($fileName);
return new ArchiveEntry($member->getLocation(), $member->getSize(), $member->getSize(), strtotime($member->getLastModifiedDate()), true);

At least in version 1.0 (the current since 2021) Member::getLastModifiedData() returns DateTime, not a textual representation of the last mtime. Hence strtotime() -- which expects a string -- fails. According to "git blame" this has always be the case(?) which surprises. I'll shortly submit a pull request.

Best

Claus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant