Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal dialog boxes invisible after upgrade to v0.12 #1226

Closed
osi8 opened this issue Jan 28, 2025 · 13 comments
Closed

Modal dialog boxes invisible after upgrade to v0.12 #1226

osi8 opened this issue Jan 28, 2025 · 13 comments

Comments

@osi8
Copy link

osi8 commented Jan 28, 2025

I have just updated to v0.12 and run the binary directly (with a diy systemd unit).
I had v0.11 working for a while, but after updating it seems that the modal dialogs stay invisible after opening.

I found, that they use the bootstrap .fade class for a transition, but the required .show class never gets attached.
So they keep opacity: 0 and are rendered invisibly in front of the page (you can see by the scrollbars going away from the .modal-open class on body which makes the overflow hidden).

I have attached a screenshot from developer tools.

Image

@Eugeny
Copy link
Member

Eugeny commented Jan 28, 2025

This should be already fixed in the nightly build - could you give it a try?

@wolveix
Copy link

wolveix commented Feb 22, 2025

I'm experiencing this same issue in v0.13.1. Removing .fade displays the modal again. Tested in Firefox, Chrome, and Safari.

For now, I've just added this TamperMonkey script to run on the domain:

// ==UserScript==
// @name         Fix Warpgate modal visibility
// @namespace    http://tampermonkey.net/
// @version      1.1
// @description  Fixes modal visibility on Warpgate
// @match *://warp.domain.tld/*
// @run-at document-idle
// @grant        GM_addStyle
// ==/UserScript==

(function() {
    'use strict';

    const style = document.createElement('style');
    style.innerHTML = `
        .modal-backdrop.fade {
            opacity: 1 !important;
        }
        .fade:not(.show) {
            opacity: 1 !important;
            visibility: visible !important;
            transition: none !important;
        }
    `;
    document.head.appendChild(style);
})();

@Eugeny
Copy link
Member

Eugeny commented Feb 26, 2025

Which modal are you seeing this with? I've clicked through all of them again and they all have both fade and show.

@wolveix
Copy link

wolveix commented Feb 26, 2025

With every modal it seems, e.g. clicking a connection on the landing page to view the SSH instructions, adding an SSH key to a user, etc. This was a fresh installation, for what it's worth.

@Eugeny
Copy link
Member

Eugeny commented Feb 26, 2025

Any errors in the devtools console?

@codyro
Copy link

codyro commented Feb 26, 2025

I also had this issue; however, I couldn't identify what was causing it. I was experiencing it across browsers; however, none of my staff had issues with various platforms and browsers.

I have to prop up a new version of Warpgate, so I'll see if I'm still experiencing this/provide a HAR if it's helpful.

@warp-tech warp-tech deleted a comment from wolveix Feb 26, 2025
@Eugeny
Copy link
Member

Eugeny commented Feb 26, 2025

No errors. I've just added a dummy user and a dummy target so you can hopefully see for yourself: [REDACTED]

I've removed your comment so that your URL doesn't remain in the internet forever just in case

It works for me!

Image

at this point I'm assuming it must be something client-specific - do you have any adblockers/userscripts that could be affecting it?

@wolveix
Copy link

wolveix commented Feb 26, 2025

Thanks for deleting the link :D I used an external link for exactly that reason!

Woah! I'm genuinely surprised! It happens across all of my browsers, seemingly regardless of extensions (tested Firefox, Firefox DE, Chrome, and Safari). I'll test it on another device, and report back.

@wolveix
Copy link

wolveix commented Feb 26, 2025

Okay I just tested it across Chrome and Firefox on a friend's PC (Windows 11), and yep no issues. I'm using macOS Sequoia 15.2 for what it's worth.

Edit: a colleague just tested it on macOS 12.6.3, no issues there either.

Edit: I'm at a loss here, this is very strange. I don't see any asset requests failing in browser dev tools either

@osi8
Copy link
Author

osi8 commented Feb 26, 2025

I can confirm, the problem is gone, no clue what happened.
I used to use ublock origin, now chrome downgraded the api so ublock lite is there instead. Also my network is filtered.
But from what I know about those modals and their show/shown hooks, it might be something webkit did with regards to timing of js events.
Since it is gone and reproducability is gone too (for me at least) I will close the issue.
Anyone wanting to reproduce and fix it, can just reopen.
Thanks everyone.

@codyro
Copy link

codyro commented Feb 26, 2025

@wolveix Seems to have found the culprit--it's for us weirdos using MacOS any OS + reduce motion: #1271 (comment)

@wolveix
Copy link

wolveix commented Feb 26, 2025

@codyro it can actually effect any OS :) If reduce motion is set at the system level, it will happen 😱

@codyro
Copy link

codyro commented Feb 26, 2025

@codyro it can actually effect any OS :) If reduce motion is set at the system level, it will happen 😱

Oh, well that's even sillier than I thought. How this is not a bigger problem for bootstrap is beyond me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants