From 8bf51ee9127fed5c9855beadf2e5c1ddbed4a2cb Mon Sep 17 00:00:00 2001 From: Daniel McDonald Date: Wed, 29 May 2024 15:38:39 -0700 Subject: [PATCH] bash doesnt run on windows gh actions out of the box, might not be hard to fix but out of scope right now --- .github/workflows/python-package-conda.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/python-package-conda.yml b/.github/workflows/python-package-conda.yml index c7e0972..c762217 100644 --- a/.github/workflows/python-package-conda.yml +++ b/.github/workflows/python-package-conda.yml @@ -57,7 +57,7 @@ jobs: strategy: fail-fast: true matrix: - os: ["ubuntu-latest", "macos-13", "macos-14", "windows-latest"] + os: ["ubuntu-latest", "macos-13", "macos-14"] python_version: ${{ fromJSON(needs.conf.outputs.supported_pythons) }} use_conda: [true, false] steps: @@ -69,12 +69,6 @@ jobs: miniforge-version: ${{ env.miniforge_version }} miniforge-variant: ${{ env.miniforge_variant }} environment-file: ci/conda_host_env.yml - - name: Setup for Windows - if: ${{ matrix.os == 'windows-latest' }} - run: | - # Set bash executable explicitly since Make may pick wrong shell - # borrowed from https://github.com/drivendataorg/cookiecutter-data-science/pull/319/files - echo "BASH_EXECUTABLE=$(which bash)" >> "$GITHUB_ENV" - name: Install dependencies (conda) if: ${{ matrix.use_conda }} shell: bash -l {0}