-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Emit application events on wadm topic #285
Comments
I'd also add manifest deploy/undeploy events to this list. You can kind of get at them from the My ideal scenario would be that we either refactor how the |
after scanning some code, here's what I am thinking:
if let Err(e) = self
.status_publisher
.publish_status(format!("{}.{}", &name, &parsed_event), Status::new(
StatusInfo::appropriate_variant_based_on_parsed_event_type(format!({&parsed_event}))
vector_of_all_scalers_statuses
))
.await
{
warn!(error = ?e, "Failed to publish application status");
} somethings I have doubts on
|
I think here we should be able to publish to the topic just fine, but we won't actually be able to persist that status in the status stream. For a first PR we could add these new events which would be available for subscribing, but we'd have to publish the old status events on the old topic still. Using a new topic that's not technically in a stream would be easy, but if we wanted to persist them in a stream we'd have to come up with a good way to limit the number of events we keep for a particular lattice/application
The payloads should be per-event IMO, the overall application status could still include all of the scaler statuses and the individual events could include smaller sets of information. What I would see as useful
🔮 As a future change, I'm thinking that this could be a useful status extension:
|
It would be good to have some more events to be able to subscribe to for outside systems to understand the state of an application. These are a few events that I know I'd be interested in using but this shouldn't be considered exhaustive.
The text was updated successfully, but these errors were encountered: