Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Remove source_config and target_config #535

Open
brooksmtownsend opened this issue Jan 2, 2025 · 0 comments
Open

[CHORE] Remove source_config and target_config #535

brooksmtownsend opened this issue Jan 2, 2025 · 0 comments
Labels
good first issue Good for newcomers rust Pull requests that update Rust code

Comments

@brooksmtownsend
Copy link
Member

These configuration options have been deprecated for like 6 minor versions now, we can fully remove them.

We should both:

  1. Change source_config and target_config validation to an error instead of a warning
  2. Remove the fields and the deserialization logic entirely.
@brooksmtownsend brooksmtownsend added good first issue Good for newcomers rust Pull requests that update Rust code labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brooksmtownsend