Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASIX: Fix thread termination logic #4396

Open
theduke opened this issue Jan 9, 2024 · 1 comment · May be fixed by #4397
Open

WASIX: Fix thread termination logic #4396

theduke opened this issue Jan 9, 2024 · 1 comment · May be fixed by #4397
Assignees
Labels
bug Something isn't working 📦 lib-wasi About wasmer-wasi lib-wasix Issues related to the WASIX toolchain. priority-medium Medium priority issue

Comments

@theduke
Copy link
Contributor

theduke commented Jan 9, 2024

Currently our thread termination tracking logic is quite scuffed.

There is a global watchable handle that is supposed to hold thread status.

But the status is actually also used to figure out if a thread should terminate in __asyncify() calls.

Calling WasiThread::terminate() currently succeeds immediately, because it sets said status.

We need to separate things out into a "should shut down" status and a "has shut down" status.

@theduke theduke added bug Something isn't working 📦 lib-wasi About wasmer-wasi lib-wasix Issues related to the WASIX toolchain. labels Jan 9, 2024
@theduke theduke self-assigned this Jan 9, 2024
Copy link

linear bot commented Jan 9, 2024

@theduke theduke linked a pull request Jan 9, 2024 that will close this issue
@syrusakbary syrusakbary added the priority-medium Medium priority issue label Jan 16, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2024
@theduke theduke reopened this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📦 lib-wasi About wasmer-wasi lib-wasix Issues related to the WASIX toolchain. priority-medium Medium priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants