Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomFile in mem_fs can only be read once #5375

Open
Arshia001 opened this issue Feb 3, 2025 · 0 comments
Open

CustomFile in mem_fs can only be read once #5375

Arshia001 opened this issue Feb 3, 2025 · 0 comments
Labels
bug Something isn't working 📦 lib-vfs About wasmer-vfs lib-wasix Issues related to the WASIX toolchain. priority-medium Medium priority issue

Comments

@Arshia001
Copy link
Member

More context: #5374

Running mounted commands was broken because CustomFile is backed by a VirtualFile, and VirtualFile stores its offset whereas other file types are just pointers to file data. The issue was worked around in #5374, but more uses of copy_reference (which creates CustomFiles) exist and I'm not sure what other code paths are broken as a result.
@theduke theduke added bug Something isn't working 📦 lib-vfs About wasmer-vfs lib-wasix Issues related to the WASIX toolchain. labels Feb 3, 2025
@Arshia001 Arshia001 added the priority-medium Medium priority issue label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working 📦 lib-vfs About wasmer-vfs lib-wasix Issues related to the WASIX toolchain. priority-medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theduke @Arshia001