Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly type useQuery #2361

Open
infomiho opened this issue Oct 28, 2024 · 0 comments
Open

Properly type useQuery #2361

infomiho opened this issue Oct 28, 2024 · 0 comments
Labels
shouldfix We should do/fix this at some point

Comments

@infomiho
Copy link
Contributor

infomiho commented Oct 28, 2024 •
edited by sodic
Loading

For users to get benefits of type auto-complete in their IDE, we should properly type the options param of our useQuery helper:

wasp/waspc/data/Generator/templates/sdk/wasp/client/operations/hooks.ts

Line 18 in 73e5532

options?: any

Also, useQuery's type says that the payload is always optional (but this actually depends on the operation). We should fix that too
@infomiho infomiho added the shouldfix We should do/fix this at some point label Oct 28, 2024
@sodic sodic changed the title Type the useQuery's options param instead of using any Properly type useQuery Nov 22, 2024
@sodic sodic mentioned this issue Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
shouldfix We should do/fix this at some point
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@infomiho