Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncaugth exception causes no response #155

Open
robstoll opened this issue Dec 20, 2021 · 0 comments
Open

uncaugth exception causes no response #155

robstoll opened this issue Dec 20, 2021 · 0 comments
Assignees
Labels

Comments

@robstoll
Copy link
Contributor

Express does currently (v 4.17.x) not forward exceptions to the next middleware which means the corresponding response will never finish (until a timeout occurs from the caller side).

Wrap routes into a handlingErrors function

@robstoll robstoll added the Bug label Dec 20, 2021
@robstoll robstoll self-assigned this Dec 20, 2021
robstoll added a commit to tegonal/datablue that referenced this issue Dec 22, 2021
the /fountains endpoint now requires sw and ne query parameter instead of city

moreover:
- require a location for byId so that we can look it up in cache
- fix TestCityBounds (water-fountains#157)
- failure handling for cache populati
- send 404 in case json object is undefined (and not only log error
  and send undefined)
- catch errors and send to next middleware (water-fountains#155)
- removed database.service.ts
- increased REQUEST_LIMIT to 10MB as we query more fountains now
- updated Api.yaml accordingly
- updated express from 4.17.1 to 4.17.2
- update node-cache from 4.2.1 to 5.1.2

cleanup:
- use BoundingBox instead of separate minLng, minLat... as parameter
- added last_scan to FountainCollection and provide a factory function
  which set it automatically to new Date()
- fix binding in router.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Verify
Development

No branches or pull requests

1 participant