Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create menmonic / vanity aliases #43

Open
ralfhauser opened this issue Feb 10, 2020 · 4 comments
Open

create menmonic / vanity aliases #43

ralfhauser opened this issue Feb 10, 2020 · 4 comments

Comments

@ralfhauser
Copy link
Member

e.g. "trevi" goes for Q185382 or rather /Q185382 so ultimately
https://h2o.do/trevi
will redirect to
https://h2o.do/it-roma?l=de&i=Q185382

Level 1) just a hard-coded list (in front-end or server wherever it is easier)
Level 2) a GUI where new aliases can be added to a database / or text file (provided they are not yet taken)

@ralfhauser
Copy link
Member Author

to avoid code duplication/high maintenance, created in route-validator.service.ts the function
lookupAlias

==> works, but only in the 2nd attempt !

If a city is once loaded, then the detail-window sought opens.
If a city is new after datablue restart, the correct city loads, but no detail window opens

@stankomix
Copy link

@ralfhauser
I think that issue is with API call fountain details this is why seem that not load

@ralfhauser
Copy link
Member Author

  1. also allow for vanity aliases based on OSM node ID e.g. https://beta.water-fountains.org/jetDeau
  2. if no fountain in the current city is found by the search, in a pop-up offer to open vanity-alias

ralfhauser pushed a commit to water-fountains/proximap that referenced this issue Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants