Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not load constants/locations/fountain-properties upon each city change, etc. #47

Open
ralfhauser opened this issue Mar 21, 2020 · 3 comments
Open

do not load constants/locations/fountain-properties upon each city change, etc. #47

ralfhauser opened this issue Mar 21, 2020 · 3 comments

Comments

@ralfhauser
Copy link
Member

ralfhauser commented Mar 21, 2020 •
edited
Loading

see also water-fountains/proximap#335 "lazy load"
ralfhauser pushed a commit to water-fountains/proximap that referenced this issue Mar 21, 2020
https://github.com/water-fountains/datablue/issues/47
972138c
ralfhauser pushed a commit to water-fountains/proximap that referenced this issue Mar 21, 2020
https://github.com/water-fountains/datablue/issues/47
2f42b77
ralfhauser pushed a commit to water-fountains/proximap that referenced this issue Mar 21, 2020
https://github.com/water-fountains/datablue/issues/47
fa6d4e0
ralfhauser pushed a commit to water-fountains/proximap that referenced this issue Mar 21, 2020
https://github.com/water-fountains/datablue/issues/47
f0e5c77
ralfhauser pushed a commit that referenced this issue Mar 21, 2020
https://github.com/water-fountains/datablue/issues/47
6795ebe
ralfhauser pushed a commit that referenced this issue Mar 22, 2020
https://github.com/water-fountains/datablue/issues/47
514ecd2
ralfhauser pushed a commit that referenced this issue Apr 2, 2020
https://github.com/water-fountains/datablue/issues/47
ab21aab
ralfhauser pushed a commit that referenced this issue Apr 4, 2020
https://github.com/water-fountains/datablue/issues/47
8d20ca7
@ralfhauser ralfhauser mentioned this issue Apr 4, 2020
Merged
ralfhauser pushed a commit to water-fountains/proximap that referenced this issue Apr 4, 2020
https://github.com/water-fountains/datablue/issues/47
29fc5f9
@ralfhauser ralfhauser changed the title do not load locations/fountain-properties upon each city change, etc. do not load constants/locations/fountain-properties upon each city change, etc. Apr 4, 2020
ralfhauser pushed a commit to water-fountains/proximap that referenced this issue Apr 4, 2020
https://github.com/water-fountains/datablue/issues/47
66f7840
ralfhauser pushed a commit to water-fountains/proximap that referenced this issue Apr 4, 2020
https://github.com/water-fountains/datablue/issues/47
3db8cb0
@ralfhauser
Copy link
Member Author

ralfhauser commented Apr 4, 2020 •
edited
Loading

in proximap, pls use sharedConstants.LANG in

  1. fountain-property.components.ts:27
  2. intro-window.component.html:10
  3. mobile-menu.component.html:62
  4. navbar.component.html:16
  5. sharedConstants.CACHE_FOR_HRS_i45db instead of "48" in mobile-menu.component.html:65

ralfhauser pushed a commit to water-fountains/proximap that referenced this issue Apr 4, 2020
https://github.com/water-fountains/datablue/issues/47
32ba916
@ralfhauser
Copy link
Member Author

ralfhauser commented Apr 5, 2020 •
edited
Loading

image
these two menus no longer work - is that a side effect of this effort here ?

@ralfhauser
Copy link
Member Author

  1. when I do
    http://localhost:4200/test?l=en
    the language is ignored ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ralfhauser