-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make deep links shorter #159
Comments
https://water-fountains.org/zh?l=d&qt=id&db=wikidata&id=Q55170432 a) eventually, we might do another try for a shorter domain URL again |
|
Re 3) as all wikidate id's start with "Q" and no OSM does, please implement this as a quick-win (and make the "database" parameter optional for now as we currently only have 2 possible databases) So we probably could get to |
Is it too long to spell out zurich and lang? 3b) https://beta.water-fountains.org/zurich?lang=de&idval=Q55170432 this 58 chars, and the maximum allowable before getting split (according to first image) is 76 chars, so we still have room for long location names. |
No, it is not. But if we touch it, I would allow for the shorter variant in parallel and what is the rationale to make it as long as "idval" and not just "id" or even "i" ? |
I am unhappy with "idval" but "id" seemed to be used internally as it caused the app to crash when I would use it. |
then pls go vor "i" that is even shorter |
==> "CH-ZH" Re b2) that should be semantically taken out of wikidata |
Here is the new format: |
The old urls should still be compatible. |
The language in https://beta.water-fountains.org/us-nyc?l=en does not work :(
|
The URLs in 2 and 3 don't work. Is 4b2 implemented ? |
I only implemented the shortest variant, not the intermediate ideas. That is why I didn't implement the variants 2 and 3 b 3a works when you include the beta before. 4b2 is a new issue |
Will it work without "beta" once you released production ? |
I don't see why not. |
Then, let's verify and close this once we are there |
|
#244 is still pending. Fountains are aggregated and stored on a city-by-city basis, so if only an identifier is provided, an extra step is required before fetching the data, to search city databases for specific fountain. In the long term, it makes sense to upgrade how the aggregated fountains are stored and use a database instead of the current simple cache solution. |
I guess the "extra step" would be to create on the bi-hourly region-reload an index of all Q-Ids-vs. City. But since we have < 10'000 fountains covered, such an index should be quick to be built in no time and querying it should be even quicker |
see also water-fountains/import2wikidata#10 |
The URL gets split on 2 pages
The text was updated successfully, but these errors were encountered: