Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load fountain details from server only if refreshing or server data corrupted #321

Open
ralfhauser opened this issue Jan 26, 2020 · 2 comments

Comments

@ralfhauser
Copy link
Member

see also water-fountains/datablue#41

ralfhauser pushed a commit that referenced this issue Feb 20, 2020
ralfhauser pushed a commit that referenced this issue Feb 23, 2020
on img description
@ralfhauser
Copy link
Member Author

ralfhauser commented Mar 2, 2020

  1. location and properties should not be loaded so often:
    a) first approach: copy 2 files Lazy load locations/properties #334
    b) todo: include them upon json packaging the proximap app instead of copying

  2. the proximap/src/app/data.services.ts:incomplete() function should be shared between proxima and datablue (for flatten out / reduce calls to osm, wiki*, flickr, mapillary, ... datablue#45) by inclusion

@ralfhauser
Copy link
Member Author

  1. do not flush redux cache and alike (in proximap/src/app/route-validator.services.ts:validateWikidata() the this.dataService.fountainsAll) until it is properly determined that they really belong to the wrong city

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant