Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

looks like the completeness check for cached data is only half baked #476

Open
robstoll opened this issue Dec 10, 2021 · 0 comments
Open
Labels
Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs

Comments

@robstoll
Copy link
Contributor

robstoll commented Dec 10, 2021

Describe the bug
I don't have a concrete scenario but looking at the code, we see the following three comments at the end of isCachedDataComplete

//validate operator into
//validate artist info
//validate wikipedia summary

So it sound like we might have the case that the cached data does not have all data and using the cached data could thus result in a view of a fountain which is incomplete (e.g. the artist is not shown -- we have encountered this for the Sardona fountain at some point, could have been the reason) . I don't know whether this is intentional or not

@robstoll robstoll added the Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs label Dec 10, 2021
@robstoll robstoll changed the title looks like the completness check for cached data is only half baked looks like the completeness check for cached data is only half baked Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug https://github.com/dotnet/roslyn/wiki/Labels-used-for-issues#bugs
Projects
None yet
Development

No branches or pull requests

1 participant