Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically defining feed composition in GUI #1410

Open
adam-a-a opened this issue May 28, 2024 · 2 comments
Open

Dynamically defining feed composition in GUI #1410

adam-a-a opened this issue May 28, 2024 · 2 comments
Assignees
Labels
Priority:High High Priority Issue or PR ui

Comments

@adam-a-a
Copy link
Contributor

adam-a-a commented May 28, 2024

For flowsheets that use the MCAS property model, we should be able to allow the user to define what ions/solutes are in the desired composition. While we can have some default composition with default concentrations to start if the user doesn't care to change this, the user should be able to define feed composition. I would consider this to be one of the core requirements that any water treatment modeling application should have. Now that we have "model config options" for flowsheets, we should be able to setup feed composition in the same manner.

@MichaelPesce @dangunter

@adam-a-a adam-a-a added the ui label May 28, 2024
@adam-a-a
Copy link
Contributor Author

The nf_ui example is the first example that comes to mind although the user would also need to provide solute properties which are required by the nf unit model. Namely, they'd need to provide molecular weight, charge, Stokes radius, and diffusivity for each component. We might be able to get away with excluding molecular weight and charge since I built in some capability to load those automatically, granted that said components are found in a lookup table corresponding to the periodic table.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label May 30, 2024
@avdudchenko
Copy link
Contributor

We do have the build options that could be used for this, however we would need to enable user to dynamically add additional options in form of ion species predefined by developer. - an alternative might be to give a user an option to point to a config file? This would also remove the need for a user to always reenter all the options etc. but not sure if its really a good options

  • ideally the user would need to be able to save their "build options" along side being able to enter them in to the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR ui
Projects
None yet
Development

No branches or pull requests

5 participants