Modified FlightRadar24 link to open in new tab with external link indicator #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtheguy
changed the title
|
looks good to me! |
|
Hi @watson - what would it take to merge this PR? Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When using the AirplaneJS software, a user may want to single-handedly open the FlightRadar24 information for an aircraft quickly. This pull request enables that functionality by opening the external link to the FlightRadar24 website in a new tab by default. A user can close the tab to return to the AirplaneJS session in another. This addresses issue #4.
Approach
The generated URL to FlightRadar24 will now target a new tab through the addition of
target="_blank", and include an indicator that it is an external link. This is good practice for any site navigating users away from the parent domain.Testing
Tested and working on Chrome 63.0.3239.84, Mac OS X El Capitan: