Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace action responses with intents #3

Open
CyrusJia opened this issue May 10, 2017 · 4 comments
Open

Replace action responses with intents #3

CyrusJia opened this issue May 10, 2017 · 4 comments

Comments

@CyrusJia
Copy link

No description provided.

@jsdelfino
Copy link
Member

Thanks for your contribution. What you're suggesting here makes sense to me. I reviewed your changes and made some comments (the main comment is that your IDE seems to have introduced many formatting changes that make the diff difficult to review...) I will happy to review a revised version of the pull request. Thank you!

@CyrusJia
Copy link
Author

CyrusJia commented May 16, 2017 •
edited
Loading

I have updated the pull request after revisions as per your comments. Please take a look. Thanks.

@CyrusJia
Copy link
Author

I've updated the pull request based on those two suggestions. Please let me know if everything is finalized for the merge. Thanks!

@jsdelfino
Copy link
Member

Merged your changes from pull request #4 in commit 454b22c.

Leaving the issue open for now as I think we're missing changes to watson.json (removing the Watson Conversation dialog nodes as they're not necessary anymore.)

@jsdelfino jsdelfino changed the title Pull Request regarding replacing action responses with intent responses Replace action responses with intents May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsdelfino @CyrusJia