chore: More tests for common/base/ package #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsdt
commented
Mar 20, 2025
| @@ -1,4 +1,4 @@ | |||
| export type ObjectValues<T extends object> = T[keyof T]; | |||
| export function objectValues<T extends object>(obj: T): ReadonlyArray<T[keyof T]> { | |||
| return Object.values(obj); | |||
Member
Author
There was a problem hiding this comment.
Not frozen at runtime, only protected through typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
[X] No dependencies added
[X] Tiny change to
common/base/src/types/utils.tsto freeze the ReadOnly array at runtime to match the expected behaviourUnit tests
packages/common/base/**/*Should disallow when prefix is invalidWould love some feedback on this!
Personally have used CrossMint on couple of projects and love what you do.
Hope you find this helpful!
--
Subtle sale (sorry for the shameless promotion):
We help with your QA while you can focus on what you do best - pushing forward your roadmap.