We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addFloatSamplesToInputBuffer
Hi, I found that it could be a numerical truncation bug in
sonic/sonic.c
Line 519 in 8694c59
*samples could be out of range [-1.0, 1.0].
*samples
It should be guaranteed that the value of (*samples++) * 32767.0f is in the range [-32767, 32767], otherwise noise will be introduced. Just like here:
(*samples++) * 32767.0f
Lines 271 to 277 in 8694c59
Thanks.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi, I found that it could be a numerical truncation bug in
sonic/sonic.c
Line 519 in 8694c59
*samples
could be out of range [-1.0, 1.0].It should be guaranteed that the value of
(*samples++) * 32767.0f
is in the range [-32767, 32767], otherwise noise will be introduced. Just like here:sonic/sonic.c
Lines 271 to 277 in 8694c59
Thanks.
The text was updated successfully, but these errors were encountered: