Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the lower density of the data grid table by default #7074

Open
wants to merge 6 commits into
base: 4.10.0
Choose a base branch
from
Open

Use the lower density of the data grid table by default #7074

wants to merge 6 commits into from
+7 −4

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Oct 4, 2024 •
edited
Loading

Description

Removed density selector in wz discover and applying compact density styles to the table

Issues Resolved

#7052

Evidence

Captura de pantalla 2024-10-15 a la(s) 10 23 36 a  m

Test

  • Go to the events tab of each module and check in the table that the density selector does not appear and that the table styles are displayed in compact mode as in the screenshot shown in the evidence.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm self-assigned this Oct 4, 2024
@chantal-kelm chantal-kelm linked an issue Oct 4, 2024 that may be closed by this pull request
Use the lower density of the data grid table by default #7052
Open
@chantal-kelm chantal-kelm marked this pull request as ready for review October 15, 2024 13:34
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.11% ( 4174 / 29576 )
Branches 9.23% ( 1778 / 19259 )
Functions 13.81% ( 986 / 7139 )
Lines 14.3% ( 4071 / 28462 )

guidomodarelli
guidomodarelli approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

CR 🟢

Malware Detection - 🟢

image

File Integrity Monitoring - 🟢

image

Threat Hunting - 🟢

image

Vulnerability Detection - 🟢

image

MITRE ATT&CK - 🟢

image

PCI DSS - 🟢

image

GDPR - 🟢

image

HIPAA - 🟢

image

NIST 800-53 - 🟢

image

TSC - 🟢

image

Docker - 🟢

image

Amazon Web Services - 🟢

image

Google Cloud - 🟢

image

GitHub - 🟢

image

Office 365 - 🟢

image

@Machi3mfl Machi3mfl self-requested a review November 1, 2024 13:24
@Machi3mfl
Copy link
Member

Tests

CR 🟢

Malware Detection - 🟢
Screenshot 2024-11-01 at 6 12 35 PM
File Integrity Monitoring - 🟢
Screenshot 2024-11-01 at 6 13 11 PM
Threat Hunting - 🟢
Screenshot 2024-11-01 at 6 13 50 PM
Vulnerability Detection - 🟢
Screenshot 2024-11-01 at 6 14 13 PM
MITRE ATT&CK - 🟢
Screenshot 2024-11-01 at 6 14 38 PM
PCI DSS - 🟢
Screenshot 2024-11-01 at 6 15 04 PM
GDPR - 🟢
Screenshot 2024-11-01 at 6 15 23 PM
HIPAA - 🟢
Screenshot 2024-11-01 at 6 15 57 PM
NIST 800-53 - 🟢
Screenshot 2024-11-01 at 6 16 24 PM
TSC - 🟢
Screenshot 2024-11-01 at 6 16 52 PM
Docker - 🟢
Screenshot 2024-11-01 at 6 17 23 PM
Amazon Web Services - 🟢
Screenshot 2024-11-01 at 6 17 53 PM
Google Cloud - 🟢
Screenshot 2024-11-01 at 6 18 18 PM
GitHub - 🟢
Screenshot 2024-11-01 at 6 18 58 PM
Office 365 - 🟢
Screenshot 2024-11-01 at 6 19 21 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@guidomodarelli guidomodarelli guidomodarelli approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the lower density of the data grid table by default
3 participants
@chantal-kelm @Machi3mfl @guidomodarelli