Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using hard-coded values in configuration files #77

Closed
Tracked by #485
AlexRuiz7 opened this issue Dec 12, 2023 · 1 comment · Fixed by #557
Closed
Tracked by #485

Avoid using hard-coded values in configuration files #77

AlexRuiz7 opened this issue Dec 12, 2023 · 1 comment · Fixed by #557
Assignees
Labels
level/task Task issue request/operational Operational requests type/enhancement Enhancement issue

Comments

@AlexRuiz7
Copy link
Member

AlexRuiz7 commented Dec 12, 2023

Description

The wazuh-indexer configuration files use hard-coded values in files such as jvm.prod.options. The original files use variables, which is vastly preferred.

https://github.com/wazuh/wazuh-indexer/blob/4.9.0/distribution/src/config/

-Xms${heap.min}
-Xmx${heap.max}

${heap.dump.path}
# specify an alternative path for JVM fatal error logs
${error.file}
## JDK 8 GC logging
8:-XX:+PrintGCDetails
8:-XX:+PrintGCDateStamps
8:-XX:+PrintTenuringDistribution
8:-XX:+PrintGCApplicationStoppedTime
8:-Xloggc:${loggc}
8:-XX:+UseGCLogFileRotation
8:-XX:NumberOfGCLogFiles=32
8:-XX:GCLogFileSize=64m
# JDK 9+ GC logging
9-:-Xlog:gc*,gc+age=trace,safepoint:file=${loggc}:utctime,pid,tags:filecount=32,filesize=64m

@AlexRuiz7 AlexRuiz7 added level/task Task issue type/enhancement Enhancement issue labels Dec 12, 2023
@AlexRuiz7 AlexRuiz7 added the request/operational Operational requests label Feb 19, 2024
@AlexRuiz7 AlexRuiz7 linked a pull request Nov 21, 2024 that will close this issue
3 tasks
@AlexRuiz7
Copy link
Member Author

Solved in #557

@AlexRuiz7 AlexRuiz7 self-assigned this Nov 21, 2024
@wazuhci wazuhci moved this to Done in Release 5.0.0 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue request/operational Operational requests type/enhancement Enhancement issue
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant