Set defaults on a per class basis

[sorenmalling]

How about we introduce a Defaults annotation kind of like this

#[Route\Defaults(prefix: 'uri-prefix', format: 'json')

[mhsdesign]

i dont really understand but like:

#[Route\Defaults(prefix: 'uri-prefix', format: 'json')
class MyController
{
   #[Route('lol', method: "GET")
   public function lolAction()
   {}
}

would result in uri-prefix/lol ?

[bwaidelich]

Why not re-use the existing names from the routing config (it's not super nice, but at least that would make it consistent), i.e.:

class MyController
{
   #[Route(uriPatter: "foo", defaults: ['@format': 'json'], httpMethods: ['GET'])
   public function lolAction()
   {}
}

[sorenmalling]

Why not re-use the existing names from the routing config (it's not super nice, but at least that would make it consistent), i.e.:

My attempt to make config key more simple. format is a part of default - but we read all other defaults from the position of the annotation. So, defaults: {@format: ..} can simply be a format property :)

[sorenmalling]

i dont really understand but like:

#[Route\Defaults(prefix: 'uri-prefix', format: 'json')
class MyController
{
   #[Route('lol', method: "GET")
   public function lolAction()
   {}
}

would result in uri-prefix/lol ?

Exactly, routes for this class all have contacts as a "prefix" - son instead of repeating yourself in each annotation, we can "prefix" the class. It's possible now by setting a Route('prefix') on the class - this is about making single purpose annotations

[mhsdesign]

yes id consider it more clean to have a separate annotation for this than to reuse the existing one though i dont like your proposed name ^^ naming things i know ...

[lorenzulrich]

I like prefix very much, because currently I must repeat api/v1 everywhere. This way I can just put it to the AbstractApiController.

[lorenzulrich]

However, the question if method(s) should be an array is valid. With the current approach, I think an action can only be used with one method, while it can make sense to have PUT and POST in the same action.

[sorenmalling]

dont like your proposed name ^^ naming things i know ...

@mhsdesign

Route Defaults - the idea from the defaults configuration of the Routes.yaml, but with keys that add values to defaults in this new context

#Route\Defaults(prefix: 'api/v1', format: 'json')

Say it out load: Route Defaults is prefix api/v1 and format json

and on the method

#Route\Post(path: 'contacts')

Route is POST contacts

Together it will be be

Route is POST api/v1/contacts format json

[sorenmalling]

And for @lorenzulrich example:

on the class

#Route\Defaults(prefix: 'api/v1', format: 'json')

and on the method

#Route\Post(path: 'contacts', method: {'GET','POST'})

Route is GET and POST contacts

Together it will be be

Route is GET and POST api/v1/contacts format json

[mficzel]

I would like to see the first implementation of annotation routes be close to the yaml configuration and not introduce other new features yet.

We may want that later after actually working with route annotations. If it can be treated as a seperate feature it probably should.