Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockContentFragment_ContentElement_Structured does not support getValue() #15

Open
benpeter opened this issue Jul 6, 2023 · 7 comments · May be fixed by #26
Open

MockContentFragment_ContentElement_Structured does not support getValue() #15

benpeter opened this issue Jul 6, 2023 · 7 comments · May be fixed by #26

Comments

@benpeter
Copy link

benpeter commented Jul 6, 2023

ContentElement::getValue is not currently supported in MockContentFragment_ContentElement_Structured

@stefanseifert before I consider contributing support for that, is there anything that would speak against supporting the method, or was it simply an effort based decision not to support it so far?

@stefanseifert
Copy link
Member

would be great if you can come up with a PR! - happy to include it

@SergiioDev
Copy link

Hello, are there any updates about this? We need this implementation

@benpeter
Copy link
Author

Hi @SergiioDev -- no, sorry: in the case at hand back then, I reverted to another solution because I didn't have the time to implement support for ContentElement::getValue

@SergiioDev
Copy link

What was your solution change the code to pass the tests?
This will be implemented in future updates? a lot of people are complaining about this

@benpeter
Copy link
Author

I did mocks for just what I needed in project scope.
it will be implemented if you do ;-)

@koenkicken
Copy link
Contributor

Contributed my code at #26 which fixed this issue for me. Probably not the perfect solution, but worked for our use case. Feel free to edit!

@saguilaar
Copy link

amazing thank you @koenkicken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants