Redesign for v1 #48
Merged
Redesign for v1 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily to leverage upstream server. Make use of nginx default round robin load balancing. Test using SSL also.
…20 just to save on memory.
Discovered that the round robin load balancing allocates all of its peers upon initialization based on the servers in an upstream, and then never again. I decided to not mess with this mechanism and instead just let it initialize then find and cache pointers to the round robin peers that point to my jdomain addresses. That allows me to set the peers down state, since changing that on the server has no effect after the round robin initialization has run. I also decided to allocate the max IPs worth of peers up front and set the server's naddrs to the max IPs in order to trick the round robin initialization into also allocating that many peers from the start. I then reset the server naddrs to the number of IPs we actually resolved, and set the offset of peers to down so they aren't used. It feels a little bit like a hack, but it is the safest thing to do as far as memory management goes.
Also removing retry_off because it's a dumb parameter
… to avoid pointer arithmetic
|
Compatibility with virtual host traffic status module is as good as it can be but that module has a shortcoming in which it only considers one address in a server. I have raised this issue to start the conversation, but we will just have to live with it for now. I may open a PR for that myself. |
… OS versions and nginx versins using a matrix
…ifferent OS versions and nginx versins using a matrix" This reverts commit 3434df7.
…t many different OS versions and nginx versins using a matrix"" This partially reverts commit 7360e31a269db611b22ee5b788e37b790fe57bf3. This also tries to solve the issue with docker build args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #32
Resolves wdaike/ngx_upstream_jdomain#7
Resolves wdaike/ngx_upstream_jdomain#15
This change focuses on making the module leverage nginx's upstream server structure so it can be more compatible with nginx modules.
Each jdomain directive creates an underlying server object and also keeps track of the round robin peers which are created from that server so that their states can be manipulated directly.
This change further simplifies the module by relying on the default round robin load balancer built into nginx core. Instead of doing all of the peer initialization, manual peer selection and SSL session handling, this module calls the round robin initialization and round robin peer initialization, and all of those things are taken care of by nginx code. So basically this module only sets up handlers for the initialization and peer initialization phases of a load balancer module, whereas it used to handle init, init peer, get peer, free peer, set session, and save session... most of which is quite unnecessary. Now this module can focus on its sole responsibility, which is to resolve a domain on an interval and overwrite peer addresses if necessary.
Furthermore, this change aims to add much more thorough testing, especially where compatibility with other nginx modules is concerned.
TODO:
server