Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze class structure #76

Open
swissspidy opened this issue Oct 30, 2018 · 1 comment
Open

Analyze class structure #76

swissspidy opened this issue Oct 30, 2018 · 1 comment

Comments

@swissspidy
Copy link
Collaborator

Extracted from #70:

We might need to move some stuff around. For example delete_local_repository() might make more sense in the Updater instead of Runner.

@swissspidy
Copy link
Collaborator Author

Some more observations after working on #108 and other tickets:

  • The Plugin class and especially \Required\Traduttore\Plugin::register_hooks() is getting too complex. We should put all these things into different methods/functions
  • A helper method to access the WP_Filesystem API would be handy, e.g. Required\Traduttore\get_filesystem(). We could easily create a inc/namespace.php file with multiple such helper functions.
  • Could we combine Updater and Runner without any negative consequences?
  • ZipProvider might not be the best name. What about LanguagePack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant