Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm the cluster to run against before running #262

Open
guyfedwards opened this issue Oct 24, 2018 · 4 comments
Open

Confirm the cluster to run against before running #262

guyfedwards opened this issue Oct 24, 2018 · 4 comments
Labels

Comments

@guyfedwards
Copy link

guyfedwards commented Oct 24, 2018

Confirm that the user is running against the correct cluster by showing them the name and then prompting user confirmation before running the setup.

@rade
Copy link
Member

rade commented Oct 24, 2018

What do you mean by 'name'?

We are already showing the cluster. It's the confirmation prompt that is missing.

The prompt ought to be optional (via a flag) in order to cater for headless installs.

I am pretty sure we've had discussions in the past about prompts in the launcher, possibly even for this specific case - worth scouring prior github issues/PRs.

@bia
Copy link

bia commented Oct 25, 2018

Could we also include info about the K8s version the person is running in this prompt?

cc @rndstr

@rndstr
Copy link

rndstr commented Oct 25, 2018

@bia sure, what's the reasoning behind it? my understanding is the prompt is designed to make sure no mistake happens. would the user change his decision depending on the k8s version he sees there?

@rade i think this is about the cluster name since kubectl could be set up to point to an unexpected cluster.

we could also allow the cluster to be changed with a prompt that allows selection from all the clusters (kubectl config get-clusters)

@bia
Copy link

bia commented Oct 29, 2018

sure, what's the reasoning behind it?

Just giving people a complete confirmation of what they are about to set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants