Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible performance degradation because of missing index on publicKeyCredentialId #665

Open
ruudk opened this issue Dec 17, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ruudk
Copy link
Contributor

ruudk commented Dec 17, 2024

Description

I'm currently playing with this framework and noticed that the default table for the credentials does not set an index for the publicKeyCredentialId column.

Next to that, for MySQL it picks longtext. You cannot set an index on that either.

So this will be fine with a demo application, but as soon as this table grows bigger, performance will be degraded significantly.

Maybe a suggestion could be to hash the publicKeyCredentialId and use that to lookup the credential?

Example

No response

@Spomky
Copy link
Contributor

Spomky commented Jan 4, 2025

Hi @ruudk,

Indeed, this field should have an index.
I created PR #670 for that, but I'm not sure if it's the right approach. I'll mention it in the documentation.

@Spomky Spomky self-assigned this Jan 4, 2025
@Spomky Spomky added the enhancement New feature or request label Jan 4, 2025
@Spomky Spomky added this to the 5.1.0 milestone Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants