Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: source maps doesn't work (rsbuild bug) #6289

Closed
GiancarlosIO opened this issue Sep 27, 2024 · 3 comments
Closed

[Bug]: source maps doesn't work (rsbuild bug) #6289

GiancarlosIO opened this issue Sep 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@GiancarlosIO
Copy link

GiancarlosIO commented Sep 27, 2024 •
edited
Loading

Details

I think it would be good to have an issue to track this bug related to the source map generation in production mode.

This bug has already been reported in rsbuild:

web-infra-dev/rsbuild#3447

I have created this because the bug is also affecting the modern.js build.
@GiancarlosIO GiancarlosIO added the bug Something isn't working label Sep 27, 2024
@zllkjc
Copy link
Member

zllkjc commented Oct 15, 2024

I see it was already fixed in rsbuild, i will close the issue.

@zllkjc zllkjc closed this as completed Oct 15, 2024
@GiancarlosIO
Copy link
Author

hi @zllkjc yes!
but it's not already fixed in modernjs 🤔 . I think we would need to upgrade the rspack or rsbuild package in the modernjs dependencies to finally fix the source map issue 😢

@GiancarlosIO
Copy link
Author

I can see this MR: #6286 🎉

How can I upgrade rsbuild by myself? maybe configuring pnpm.overrides or I need to install rsbuild manually in my project? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GiancarlosIO @zllkjc