Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: @rsbuild/plugin-eslint The plug-in is only detected at startup. Modifying the code does not update the detection status. #2151

Closed
yangcore opened this issue Apr 19, 2024 · 6 comments
Assignees
Labels
🐞 bug Something isn't working

Comments

@yangcore
Copy link

Version

System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
    Memory: 1.23 GB / 15.77 GB
  Browsers:
    Edge: Chromium (123.0.2420.81)
    Internet Explorer: 11.0.19041.3636
  npmPackages:
    @rsbuild/core: ^0.6.3 => 0.6.4
    @rsbuild/plugin-eslint: ^0.6.4 => 0.6.4
    @rsbuild/plugin-vue2: ^0.6.3 => 0.6.3

Details

image

Reproduce link

Not available yet

Reproduce Steps

yarn dev

@yangcore yangcore added the 🐞 bug Something isn't working label Apr 19, 2024
@chenjiahan
Copy link
Member

This is a known issue, see: #2089

@chenjiahan chenjiahan self-assigned this Apr 24, 2024
@yangcore
Copy link
Author

yangcore commented Apr 25, 2024

This is a known issue, see: #2089

I used eslint-rspack-plugin and found that everything was normal. Later I saw that hooks were changed in the submission record of eslint-rspack-plugin, as shown below
image
Then I changed the hooks of eslint-webpack-plugin that @rsbuild/plugin-eslint depends on, and found that @rsbuild/plugin-eslint runs Normal, but the speed is relatively slow.
in dev modifying a file requires 0.9 seconds to compile without enabling lint, and 2.3 seconds to enable lint.

@chenjiahan
Copy link
Member

Yeah, ESLint will slow down the build process

@chenjiahan
Copy link
Member

@hardfist should we use eslint-rspack-plugin at the moment?

@hardfist
Copy link
Contributor

I think it's fine to use eslint-rspack-plugin

@chenjiahan
Copy link
Member

Duplicate of web-infra-dev/rspack#6432.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants